Skip to content

adding chats pagination logic, and getChatsLength, and rename getChats that's get all chats to getAll chats #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

adding chats pagination logic, and getChatsLength, and rename getChats that's get all chats to getAll chats #3455

wants to merge 3 commits into from

Conversation

000MaDz000
Copy link

@000MaDz000 000MaDz000 commented Feb 2, 2025 •
edited
Loading

PR Details

Description

Related Issue(s)

Motivation and Context

How Has This Been Tested

Environment

  • Machine OS:
  • Phone OS:
  • Library Version:
  • WhatsApp Web Version:
  • Puppeteer Version:
  • Browser Type and Version:
  • Node Version:

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).
  • I have updated the usage example accordingly (example.js)

@000MaDz000
adding getChatsLength, getChats for pagination, getAllChats
24047c8 
getChats => will take offset and limit and get the data chunk
getAllChats => will not take anything, it's was renamed from getChats to getAllChats
getChatsLength => returns the whatsapp chats array length
@000MaDz000
fixing the limitation request error
8b53ed3
@000MaDz000
increment version for npm
c24be4c
@themazim
Copy link
Contributor

themazim commented Feb 6, 2025

works great for me, thanks!

alechkos
alechkos requested changes Mar 27, 2025
View reviewed changes
Copy link
Collaborator

@alechkos alechkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be better to not break an exciting getChats, what about to rename your getChats to smth like getChatsByOffset.

Also please revert all format changes.

package.json
@@ -1,6 +1,6 @@
{
"name": "whatsapp-web.js",
"version": "1.26.1-alpha.3",
"version": "1.26.2-alpha.3",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change the lib version here, it is being changed automatically after each release, please revert this.

tuyuribr
tuyuribr requested changes Jun 10, 2025
View reviewed changes
Copy link
Collaborator

@tuyuribr tuyuribr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, only change the code you are suposed to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuyuribr tuyuribr tuyuribr requested changes

@alechkos alechkos alechkos requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@000MaDz000 @themazim @tuyuribr @alechkos