Skip to content

feat: 🎸 hid lid in events #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hcfw007
Copy link
Contributor

@hcfw007 hcfw007 commented Jun 4, 2025

PR Details

convert @lid group participants intl @c.us ids in events.

Description

Use a fixMessageLid function to handle messages and call it in all message-related events.

Related Issue(s)

closes #3588

Motivation and Context

How Has This Been Tested

I tried group join, group leave, group info update, message create, message ack, message receive events. They all worked.

Environment

  • Machine OS:
  • Phone OS:
  • Library Version:
  • WhatsApp Web Version:
  • Puppeteer Version:
  • Browser Type and Version:
  • Node Version:

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).
  • I have updated the usage example accordingly (example.js)

@hcfw007
Copy link
Contributor Author

hcfw007 commented Jun 5, 2025

@alechkos

@ethan-tqa
Copy link

Looks like the lidHash object can be moved one level up, to be a field of the Client class instead of inside the function. This can help reduces the amount of processing for subsequent messages if the lid ID was seen before.

@ethan-tqa
Copy link

Another thing to note is that the Reaction object needs this too, field senderId.

@IngAlejandroSalazar
Copy link

IngAlejandroSalazar commented Jun 14, 2025

Hello, Thanks...try your mods in my app and it works perfectly. I hope it doesn't take long to complete the merger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Convert lid in message author and other events?
3 participants