Skip to content

Fix checking if sending to a group #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

shirser121
Copy link
Collaborator

PR Details

Description

Related Issue(s)

Motivation and Context

How Has This Been Tested

Environment

  • Machine OS:
  • Phone OS:
  • Library Version:
  • WhatsApp Web Version:
  • Puppeteer Version:
  • Browser Type and Version:
  • Node Version:

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).
  • I have updated the usage example accordingly (example.js)

Copy link
Collaborator

@alechkos alechkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alechkos alechkos requested a review from tuyuribr June 5, 2025 11:35
@@ -222,7 +222,7 @@ exports.LoadUtils = () => {
let from = chat.id.isLid() ? lidUser : meUser;
let participant;

if (chat.isGroup) {
if (chat.id.isGroup()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we check if chat.id.isGroup exists ? or chat.isGroup exists too ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuyuribr
Added check for chat.id and chat.id.isGroup existance

@alechkos alechkos requested a review from tuyuribr June 10, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants