EventListener - OpenTelemetry integration #25490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prestodb-ci
requested review from
a team,
bibith4 and
auden-woolfson
and removed request for
a team
jp-sivaprasad
force-pushed
the
opentelemetry-event-listener
branch
from
94e4a7d to
ebe86ed
Compare
aaneja
reviewed
Jul 3, 2025
presto-main/etc/config.properties
Outdated
| @@ -26,6 +26,10 @@ scheduler.http-client.idle-timeout=1m | |||
| query.client.timeout=5m | |||
| query.min-expire-age=30m | |||
|
|
|||
| tracing.tracer-type=otel | |||
There was a problem hiding this comment.
Please undo changes here, they are not needed for Presto to be useful OOTB
| @@ -183,12 +183,12 @@ public void run() | |||
| } | |||
| injector.getInstance(PasswordAuthenticatorManager.class).loadPasswordAuthenticator(); | |||
| injector.getInstance(PrestoAuthenticatorManager.class).loadPrestoAuthenticator(); | |||
| injector.getInstance(TracerProviderManager.class).loadTracerProvider(); | |||
There was a problem hiding this comment.
Please undo this since its a no-op change
There was a problem hiding this comment.
This change is needed as the Tracer provider needs to be loaded before the event listener
| /** | ||
| * Add a new block starting at current time to the trace | ||
| * @param blockName the name for the added tracing block | ||
| * @param blockName the name for the parent tracing block |
There was a problem hiding this comment.
Suggested change
| * @param blockName the name for the parent tracing block | |
| @param parentBlockName the name for the parent tracing block |
| @@ -155,6 +156,32 @@ public void startBlock(String blockName, String annotation) | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Create new span with Open Telemetry tracer | |||
There was a problem hiding this comment.
Suggested change
| * Create new span with Open Telemetry tracer | |
| Creates a new span |
we already are in the OpenTelemetryTracer class
Also add a
* @throws PrestoException if a blockName already is already used in the existing span map
There was a problem hiding this comment.
Can we keep the javadocs only on the SPI Tracer class ?
| public void startBlock(String blockName, String parentBlockName, String annotation) | ||
| { | ||
| if (spanMap.containsKey(blockName)) { | ||
| throw new PrestoException(DISTRIBUTED_TRACING_ERROR, "Duplicated block inserted: " + blockName); |
There was a problem hiding this comment.
Suggested change
| throw new PrestoException(DISTRIBUTED_TRACING_ERROR, "Duplicated block inserted: " + blockName); | |
| throw new PrestoException(DISTRIBUTED_TRACING_ERROR, String.format("Duplicate block inserted: %s ", blockName)); |
jp-sivaprasad
force-pushed
the
opentelemetry-event-listener
branch
from
1bdf496 to
754f557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate EventListener and OpenTelemetry to provide query tracing through OTel
Motivation and Context
Integrate EventListener and OpenTelemetry to provide query tracing
Impact
Test Plan
Tested locally with a custom event listener which transforms event listener data to OTel traces
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.