Skip to content

Polish #46291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed

Conversation

PiyalAhmed
Copy link
Contributor

@PiyalAhmed PiyalAhmed commented Jul 4, 2025

Remove redundant if statement from HeapDumpWebEndpoint.java and CharSequenceToObjectConverter.java
Use simply do-while loop in UrlDecoder.java

Signed-off-by: Piyal Ahmed <piya.salamence@gmail.com>
@PiyalAhmed PiyalAhmed changed the title Simplify if statement Remove redundant if statement Jul 4, 2025
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 4, 2025
Signed-off-by: Piyal Ahmed <piya.salamence@gmail.com>
@PiyalAhmed
Copy link
Contributor Author

@wilkinsona Thanks for your feedback, reverted.

Signed-off-by: Piyal Ahmed <piya.salamence@gmail.com>
@wilkinsona wilkinsona changed the title Remove redundant if statement Polish Jul 7, 2025
@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 7, 2025
@wilkinsona wilkinsona added this to the 3.4.x milestone Jul 7, 2025
@wilkinsona wilkinsona mentioned this pull request Jul 7, 2025
@wilkinsona wilkinsona modified the milestones: 3.4.x, 3.4.8 Jul 7, 2025
wilkinsona pushed a commit that referenced this pull request Jul 7, 2025
Signed-off-by: Piyal Ahmed <piya.salamence@gmail.com>

See gh-46291
@wilkinsona wilkinsona closed this in 803a29c Jul 7, 2025
@PiyalAhmed PiyalAhmed deleted the simplify-if-statement branch July 7, 2025 08:49
@wilkinsona
Copy link
Member

Thank you, @PiyalAhmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants