Skip to content

fix: Improve the getBaseUrl function #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dBianchii
Copy link

@dBianchii dBianchii commented May 23, 2025

Closes #

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

Changes the getBaseUrl to use NEXT_PUBLIC_VERCEL_PROJECT_PRODUCTION_URL instead of VERCEL_URL for production environments


Screenshots

[Screenshots]

💯

Copy link

changeset-bot bot commented May 23, 2025

🦋 Changeset detected

Latest commit: 8236b3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 6, 2025 8:01pm

@dBianchii dBianchii changed the title Improve the getBaseUrl function fix: Improve the getBaseUrl function May 23, 2025
dBianchii and others added 2 commits July 6, 2025 16:45
Co-authored-by: Julius Marminge <jmarminge@gmail.com>
@dBianchii dBianchii force-pushed the improve-getbase-url branch from 7d718bd to 0e4d2ad Compare July 6, 2025 19:45
@dBianchii dBianchii requested a review from juliusmarminge July 6, 2025 19:45
@dBianchii dBianchii marked this pull request as ready for review July 6, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants