Add validation for GCP application default credentials detector #4198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve GCP Application Default Credentials Detection
Background
Google Cloud Platform (GCP) supports multiple types of credential JSON files, each with different structures:
Currently, our detector assumes User Credentials format. According to GCP documentation, User Credentials JSON will always contain these specific fields:
client_id
client_secret
refresh_token
type
Changes
isValid()
method to ensure we only process User CredentialsImpact
This change makes our GCP credential detection more accurate by reducing false positives from other credential types (OSS-91)
closes issue-3717
Checklist:
make test-community
)?make lint
this requires golangci-lint)?