(fix) Flaky BoxOAuth detector test #4199
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BoxOauthdetectors's pattern test is using random password generator for input which does not guarantees inclusion. This PR make sure that define characters in password generation must follow inclusion. Thefunc GenerateRandomPasswordis also used bysnowflaketest. In this PR, I have moved it topkg/common/utils.goto avoid code duplication, also added test around it.Note: The
func GenerateRandomPasswordis only being used in pattern test. I could not find any better place to put it in exceptutils.goChecklist:
make test-community)?make lintthis requires golangci-lint)?