[Update] Coinbase API Detector Updated #4202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The existing Coinbase API detector was matching a deprecated credential which could not be verified. This PR updates the Coinbase detector to match correct credentials.
This PR also deprecates the Coinbase WaaS detector, as the client library it used for verification was archived and does not yield correct results. WaaS no longer seems to exist as well.
There is a Coinbase Wallet API which uses the same credentials as the rest of the Coinbase APIs, apart from some endpoints which require Wallet Secret (https://docs.cdp.coinbase.com/wallet-api-v2/docs/security#wallet-secrets). This would require a separate detector.
This PR is related to the Coinbase API Analyzer PR
Checklist:
make test-community)?make lintthis requires golangci-lint)?