Skip to content

Sendinblue rebranded to Brevo #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shahzadhaider1
Copy link
Contributor

Description:

This PR updates references from Sendinblue to Brevo, following the company's rebranding.

  • Updated naming conventions to reflect the new Brevo brand.
  • The existing API key detection logic remains unchanged, as Brevo API keys follow the same pattern as before.
  • API key verification continues to work with the same endpoint.
  • No additional changes to the verification mechanism were necessary.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@shahzadhaider1 shahzadhaider1 self-assigned this Jun 4, 2025
@shahzadhaider1 shahzadhaider1 requested review from a team as code owners June 4, 2025 15:24
@shahzadhaider1 shahzadhaider1 linked an issue Jun 4, 2025 that may be closed by this pull request
Copy link
Contributor

@nabeelalam nabeelalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Not blocking IMO, but this may be a good opportunity to add indeterminate verification results to the detector which seem to be missing.

Copy link
Collaborator

@rosecodym rosecodym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting changes while we discuss secret identity internally.

@rosecodym rosecodym dismissed their stale review June 5, 2025 14:31

discussion complete

@zricethezav zricethezav marked this pull request as draft June 6, 2025 16:30
@shahzadhaider1
Copy link
Contributor Author

Putting this PR on hold as per our internal discussion. Updating the detector type could lead to issues due to the presence of existing secrets using the old type, while newly detected secrets would use the updated type. To resolve this, we would need to run or update some migrations. However, since this change is not a high priority at the moment, we're pausing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SendInBlue Rebranded to Brevo (Detector Update)
3 participants