Enabled and Enhanced Artifactory Detector #4207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashifkhan0771
force-pushed
the
update/csm-1160
branch
from
badce59 to
3fd026a
Compare
shahzadhaider1
approved these changes
Jun 5, 2025
nabeelalam
reviewed
Jun 5, 2025
nabeelalam
reviewed
Jun 5, 2025
nabeelalam
reviewed
Jun 5, 2025
| @@ -26,14 +29,20 @@ var ( | |||
| defaultClient = detectors.DetectorHttpClientWithNoLocalAddresses | |||
|
|
|||
| // Make sure that your group is surrounded in boundary characters such as below to reduce false positives. | |||
| keyPat = regexp.MustCompile(`\b([a-zA-Z0-9]{73}|\b[a-zA-Z0-9]{64})`) | |||
| keyPat = regexp.MustCompile(`\b([a-zA-Z0-9]{64,73})\b`) | |||
| URLPat = regexp.MustCompile(`\b([A-Za-z0-9](?:[A-Za-z0-9\-]{0,61}[A-Za-z0-9])\.jfrog\.io)`) | |||
There was a problem hiding this comment.
Does ...(?:[A-Za-z0-9\-]{0,61}[A-Za-z0-9])... need to be a non-capturing group? These might require slightly more computation but I can't tell why it's grouped.
There was a problem hiding this comment.
It ensures the endpoint has at least two alphanumeric characters, and it can be up to 63 characters long, allowing hyphens (-) in the middle
There was a problem hiding this comment.
Yes, but I'm not sure if it needs to be a non-capturing group, that's extra computation. \b([A-Za-z0-9][A-Za-z0-9\-]{0,61}[A-Za-z0-9]\.jfrog\.io) yields the same output without using one.
There was a problem hiding this comment.
This isn't a blocker or anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables Artifactory detector and enhances it
Checklist:
make test-community)?make lintthis requires golangci-lint)?