Refine Dockerhub Detector for Improved Accuracy & Coverage #4219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR streamlines the Dockerhub detector to improve both its precision and recall for identifying Dockerhub Personal Access Tokens (PATs) and usernames.
Key updates include:
usernamePat
now correctly accounts for usernames starting with alphanumeric characters and allows for underscores and hyphens within the username, matching actual Dockerhub ID formats. It also refines whitespace handling for cleaner matches.accessTokenPat
is significantly enhanced. It now explicitly matches a broader set of common keywords (e.g.,docker pat
,access token
) and gracefully handles various key-value pair delimiters (colons, equals signs, quotes), ensuring tokens are found across diverse configurations.excludeHeaderPat
specifically filters out UUIDs found in benign Docker HTTP headers (e.g.,X-Docker-Upload-UUID
), preventing them from being flagged as secrets.These changes make the detector more effective by closely aligning it with real-world Docker credential patterns, leading to more accurate and relevant findings.
Checklist:
make test-community
)?make lint
this requires golangci-lint)?