Optimizes private key normalization #4224
Open
+161
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments and fewer allocations
shahzadhaider1
approved these changes
Jun 16, 2025
camgunz
reviewed
Jun 16, 2025
| result.Grow(len(raw)) | ||
|
|
||
| // Normalize per-line whitespace and discard blank lines. | ||
| lines := strings.Split(raw, "\n") |
There was a problem hiding this comment.
I can see how memory usage decreases by minimizing allocations because they have overhead, but I would guess a bigger source of memory usage is building a new array of the whole string here. If you change this loop to use strings.Find to iterate through the string line by line you can probably halve memory usage. It's more tedious and harder to read, but such is the nature of optimizing I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a single-pass approach to normalize private key strings by replacing multiple escape and platform-specific sequences using a canonical mapping.
Benchmarks (I was mainly interested in the reduced allocations)
NOTE: I see the LDAP detector also causing memory issues. I'll tackle that one next in a separate PR.