[Draft] - Optimize LDAP detector to cap combinations #4226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camgunz
reviewed
Jun 16, 2025
Comment on lines
+440
to
+443
| // We purposefully set InsecureSkipVerify because scanners very often run | ||
| // in environments where the target's certificate chain is not trusted. | ||
| // The objective is simply to confirm that the credentials *could* be | ||
| // used, not to validate the server's identity. |
There was a problem hiding this comment.
I appreciate this comment! I wonder if we should make a ticket to... idk make this configurable? It seems not ideal to send a bunch of could-be-creds to an unverified server.
camgunz
reviewed
Jun 16, 2025
| // ensures that Scanner.FromData finishes in reasonable time/allocs despite | ||
| // the N³ theoretical combination space. This guards against accidental | ||
| // performance regressions that would re-introduce the Cartesian explosion. | ||
| func BenchmarkCartesianProductExplosion(b *testing.B) { |
There was a problem hiding this comment.
I'm no Go benchmarking expert, but some suggestions:
- Do a context w/ a Deadline/Timeout
- It looks like the BenchmarkResult type will let you pull out the allocs (etc.), maybe you wanna put in a tripwire of max allocs you're expecting. I guess this also then has to become a normal test, but maybe that's more of what you're looking for anyway.
camgunz
reviewed
Jun 16, 2025
Comment on lines
+302
to
+304
| // The zero value is not meaningful; instances are produced internally by | ||
| // findOptimalCombinations. | ||
| type CredentialSet struct { |
There was a problem hiding this comment.
If this is internal you can keep it private if you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Updates the LDAP detector to improve performance and prevent a Cartesian product explosion during credential detection.
Key Changes:
Rationale:
These improvements reduce the risk of running expensive nested loops over many potential matches, ensuring that the detector remains performant even with inputs that could trigger an N³ worst-case scenario. The changes also enhance reliability by normalizing credential components before verification.
We created this PR after a client's scanner experienced an OOM event. Memory profiling identified several code paths with excessive memory usage, this detector among them.
memory profile
benchmarks
NOTE:This draft PR tests several methods to prevent the Cartesian-product explosion of results. Other approaches may exist, but these were the ones that I was able to think through.