Skip to content

Add OpenVSX detector #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Kiblyn11
Copy link

@Kiblyn11 Kiblyn11 commented Jun 17, 2025

Description:

Add a detector for OpenVSX tokens used by OpenVSX registry: https://open-vsx.org/
It use an available API endpoint on a legitimate namespace and look for permission issue error which means the token exist and is valid.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@Kiblyn11 Kiblyn11 requested review from a team as code owners June 17, 2025 20:24
@CLAassistant
Copy link

CLAassistant commented Jun 17, 2025

CLA assistant check
All committers have signed the CLA.

}

s1 := detectors.Result{
DetectorType: detectorspb.DetectorType_Generic, // Using Generic since VSX is not explicitly listed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create a new detector type. Please refer to this: Adding a New Detector

@shahzadhaider1
Copy link
Contributor

@Kiblyn11 Thanks for your contribution! I’ve done an initial review; great work so far. I’ve left some feedback for minor improvements. I’ll do a thorough review once the updates are in.

@Kiblyn11 Kiblyn11 requested a review from a team as a code owner June 18, 2025 07:10
@Kiblyn11
Copy link
Author

@shahzadhaider1 Thanks for your initial review. I have to admit I hacked this at first to check some assumptions without looking at contributing guides. I updated the detector type to be specific.

@Kiblyn11 Kiblyn11 requested a review from shahzadhaider1 June 18, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants