Update AzureDevops scanner #4244
Open
+94
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I observed one limitation with the current azure devops scanner.
It works on scanning by projects and this missed a few valid tokens that were not on a specific project I believe (ones that are used to push deliverables to visual studio marketplace). I observed how DevOps PAT tokens are verified with CLI
npx vsce verify-pat -p $TOKENand came with this new verification method.As I'm not sure how it impact existing detector I chose to keep both methods in this PR.
I also extended keywords to improve result detection (in particular vsce tokens)
Checklist:
make test-community)?make lintthis requires golangci-lint)?