Skip to content

If port is already in use open is rejected when opening the webhook #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

windkh
Copy link
Contributor

@windkh windkh commented May 1, 2023

  • All tests pass
  • I have run npm run doc

Description

To avoid unhandled exceptions in case of a port conflict when opening a webhook,
the promise rejects as soon as an error occurred from now on.

References

@danielperez9430 danielperez9430 self-requested a review May 3, 2023 08:30
@danielperez9430 danielperez9430 merged commit ab0eb18 into yagop:master May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants