Skip to content

Added Rust solutions for Chapter 1: Two Pointers #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 5, 2025

Conversation

gitsudhir
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Destiny-02 Destiny-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gitsudhir, thanks for your PR! I have reviewed the first solution file. Please check the comments and apply the suggestions to the other files in this PR as well.

@gitsudhir
Copy link
Contributor Author

@Destiny-02 Thanks for the review! I've updated the code to:

  • Follow the exact same algorithm structure as the Python solution, including nested while loops

  • Remove .to_lowercase() conversion as suggested

  • Use the same variable names for consistency with the book

Copy link
Collaborator

@Destiny-02 Destiny-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @gitsudhir !

@Destiny-02 Destiny-02 merged commit 969a1ba into ByteByteGoHq:main Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants