Added C# solutions for Chapter 8: Heaps #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destiny-02
requested changes
Jun 11, 2025
There was a problem hiding this comment.
Thanks for the PR! It's quite hard for readers to match the KMostFrequentStringsMaxHeap and KMostFrequentStringsMinHeap solutions with the python solutions. This may just be a consequence of the python to C# translation limitations. Could you check if there are ways to make it look more similar to the python solutions? e.g. match the code comments and use helper functions/classes.
Destiny-02
requested changes
Jun 14, 2025
Destiny-02
requested changes
Jun 14, 2025
Destiny-02
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.