fix: prioritize webserver_port in extraEnvVars #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing that!!! I had to use fluxcd postRenderers to be able to configure Hope it gets included in the next release. 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When overriding
FTLCONF_webserver_portvia theextraEnvVars, a duplicate key is produced. This change checks if that variable is defined inextraEnvVarsand if so, defers to that definition.Benefits
Allows users to modify the currently hardcoded
FTLCONF_webserver_portvalue.Possible drawbacks
Advanced/niche use case, could be difficult to use for beginners.
Applicable issues
Fixes #371
Additional information
Checklist