This repository was archived by the owner on Dec 22, 2023. It is now read-only.
Fix some antipatterns #654
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed some anti-patterns and best practices related to python.
Here's what I did:
Replace
for if
statements withany()
:The
any
function is a builtin python function that returnsTrue
if atleast one item in a list isTrue
, andFalse
otherwise. It makes the code more readable and is faster than using for-if conditionUse
in [...]
instead of multiple==
:In Python, it is recommended to use
variable in [a, b, c, d]
instead of sayingvariable == a or variable == b ...
since it will be much faster, and more readable.Type of change
Checklist:
Please tick all the boxes that are fulfilled by your Pull Request.
Update index.md
)README.md
, according to the givenREADME_TEMPLATE.