update adapters

Author: SmartToolFactory

app/src/main/res/layout/activity_main.xml

@@ -18,7 +18,7 @@
             app:layout_constraintBottom_toBottomOf="parent"
 
             app:defaultNavHost="true"
-            app:navGraph="@navigation/nav_graph_main"/>
+            app:navGraph="@navigation/nav_graph_main_bottom_nav"/>
 
     </androidx.constraintlayout.widget.ConstraintLayout>
 </layout>

buildSrc/src/main/java/Version.kt

@@ -1,6 +1,6 @@
 object PluginVersion {
     const val KOTLIN_VERSION = "1.4.0"
-    const val GRADLE_VERSION = "4.1.0-rc02"
+    const val GRADLE_VERSION = "4.1.0-rc03"
 
     const val NAV_SAFE_ARGS_VERSION = "2.3.0"
     const val KTLINT_VERSION = "9.3.0"

config/detekt/detekt.yml

@@ -81,7 +81,7 @@ complexity:
   LongMethod:
     active: true
     threshold: 60
-    excludes: ['**/NavigationExtensions.kt']
+    excludes: ['**/DynamicNavigationExtension.kt']
   LongParameterList:
     active: true
     functionThreshold: 6

features/home/src/main/java/com/smarttoolfactory/home/HomeFragment.kt

@@ -73,7 +73,7 @@ class HomeFragment : DynamicNavigationFragment<FragmentHomeBinding>() {
                 it?.let { event: Event<NavController?> ->
                     event.getContentIfNotHandled()?.let { navController ->
                         val appBarConfig = AppBarConfiguration(navController.graph)
-                        dataBinding!!.toolbar.setupWithNavController(navController, appBarConfig)
+                        dataBinding.toolbar.setupWithNavController(navController, appBarConfig)
                     }
                 }
             }

features/home/src/main/java/com/smarttoolfactory/home/adapter/PostListAdapter.kt

@@ -82,13 +82,13 @@ class PostDiffCallback : DiffUtil.ItemCallback<Post>() {
         oldItem: Post,
         newItem: Post
     ): Boolean {
-        return oldItem == newItem
+        return oldItem.id == newItem.id
     }
 
     override fun areContentsTheSame(
         oldItem: Post,
         newItem: Post
     ): Boolean {
-        return oldItem.id == newItem.id
+        return oldItem == newItem
     }
 }

features/home/src/main/java/com/smarttoolfactory/home/util/ViewBindings.kt

@@ -21,8 +21,13 @@ import com.smarttoolfactory.home.R
 @BindingAdapter("app:items")
 fun RecyclerView.setItems(items: List<Post>?) {
 
-    items?.let {
-        (adapter as ListAdapter<Post, *>)?.submitList(items)
+    try {
+        items?.let {
+            (adapter as? ListAdapter<Post, *>)?.submitList(items)
+        }
+    } catch (e: Exception) {
+        e.printStackTrace()
+        println("ViewBindings exception: ${e.message}")
     }
 }
 

libraries/core/src/main/java/com/smarttoolfactory/core/ui/adapter/BaseListAdapter.kt

@@ -1,6 +1,5 @@
 package com.smarttoolfactory.core.ui.adapter
 
-import android.util.Log
 import android.view.LayoutInflater
 import android.view.ViewGroup
 import androidx.annotation.LayoutRes
@@ -53,6 +52,7 @@ abstract class BaseListAdapter<ItemType>(
         position: Int,
         payloads: MutableList<Any>
     ) {
+        super.onBindViewHolder(holder, position, payloads)
 
         val item: ItemType? = currentList.getOrNull(position)
 
@@ -63,10 +63,7 @@ abstract class BaseListAdapter<ItemType>(
         }
     }
 
-    override fun onBindViewHolder(holder: BaseItemViewHolder, position: Int) {
-        println("🔥🔥")
-        Log.d(BaseListAdapter::class.toString(), "onBindViewHolder")
-    }
+    override fun onBindViewHolder(holder: BaseItemViewHolder, position: Int) = Unit
 
     /**
      * Called when a ViewHolder is created. ViewHolder is either created first time or

libraries/core/src/main/java/com/smarttoolfactory/core/ui/fragment/BaseDataBindingFragment.kt

@@ -33,7 +33,7 @@ abstract class BaseDataBindingFragment<ViewBinding : ViewDataBinding> : Fragment
 
     private var _dataBinding: ViewBinding? = null
 
-    lateinit var dataBinding: ViewBinding
+    val dataBinding: ViewBinding get() = _dataBinding!!
 
     /**
      * This method gets the layout id from the derived fragment to bind to that layout via data-binding
@@ -53,14 +53,14 @@ abstract class BaseDataBindingFragment<ViewBinding : ViewDataBinding> : Fragment
         savedInstanceState: Bundle?
     ): View? {
 
+        println("🤣 ${this.javaClass.simpleName} #${this.hashCode()} onCreateView()")
+
         // Each fragment can have it's separate toolbar menu
         setHasOptionsMenu(true)
 
         _dataBinding =
             DataBindingUtil.inflate(inflater, getLayoutRes(), container, false)
 
-        dataBinding = _dataBinding!!
-
         /**
          *   🔥🔥 Using viewLifecycleOwner instead of this(fragment) makes sure that
          *   when this fragment is retrieved from back stack another observer is not added
@@ -77,19 +77,32 @@ abstract class BaseDataBindingFragment<ViewBinding : ViewDataBinding> : Fragment
             dimensions.y = rootView.height
         }
 
-        bindViews()
-
         return rootView
     }
 
+    override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
+        super.onViewCreated(view, savedInstanceState)
+        bindViews()
+    }
+
     override fun onDestroyView() {
-        _dataBinding = null
         super.onDestroyView()
+        _dataBinding = null
+        println("🥵 ${this.javaClass.simpleName} #${this.hashCode()}  onDestroyView()")
     }
 
     /**
-     * Called from [Fragment.onCreateView] to implement bound ui items and set properties
+     * Called from [Fragment.onViewCreated] to implement bound ui items and set properties
      */
-    open fun bindViews() {
+    open fun bindViews() = Unit
+
+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        println("😀 ${this.javaClass.simpleName} #${this.hashCode()}  onCreate()")
+    }
+
+    override fun onDestroy() {
+        super.onDestroy()
+        println("🥶 ${this.javaClass.simpleName} #${this.hashCode()}  onDestroy()")
     }
 }

libraries/core/src/main/java/com/smarttoolfactory/core/ui/fragment/navhost/BaseDynamicNavHostFragment.kt

@@ -4,7 +4,6 @@ import android.os.Bundle
 import androidx.annotation.NavigationRes
 import androidx.fragment.app.activityViewModels
 import androidx.navigation.dynamicfeatures.fragment.DynamicNavHostFragment
-import androidx.navigation.fragment.NavHostFragment
 import com.smarttoolfactory.core.error.NavigationException
 import com.smarttoolfactory.core.util.Event
 import com.smarttoolfactory.core.viewmodel.NavControllerViewModel
@@ -14,7 +13,7 @@ import com.smarttoolfactory.core.viewmodel.NavControllerViewModel
  * uses [BaseDynamicNavHostFragment.createDynamicNavHostFragment] function with navigation graph
  * parameter
  */
-class BaseDynamicNavHostFragment : NavHostFragment() {
+class BaseDynamicNavHostFragment : DynamicNavHostFragment() {
 
     private val navControllerViewModel by activityViewModels<NavControllerViewModel>()
 

libraries/core/src/main/java/com/smarttoolfactory/core/util/NavigationExtensions.kt renamed to libraries/core/src/main/java/com/smarttoolfactory/core/util/DynamicNavigationExtension.kt

@@ -20,7 +20,7 @@ import org.junit.Test
 import org.junit.runner.RunWith
 
 @RunWith(AndroidJUnit4::class)
-class PostDaoCoroutinesCoroutinesFlowTest {
+class PostDaoCoroutinesTest {
 
     companion object {
         val postEntityList =

libraries/data/src/androidTest/java/com/smarttoolfactory/data/PostDaoCoroutinesCoroutinesFlowTest.kt renamed to libraries/data/src/androidTest/java/com/smarttoolfactory/data/PostDaoCoroutinesTest.kt

@@ -15,7 +15,7 @@ import org.junit.Before
 import org.junit.Rule
 import org.junit.Test
 
-class PostDaoCoroutinesRxJavaTest {
+class PostDaoRxJavaTest {
 
     companion object {
         val postEntityList =

libraries/data/src/androidTest/java/com/smarttoolfactory/data/PostDaoCoroutinesRxJavaTest.kt renamed to libraries/data/src/androidTest/java/com/smarttoolfactory/data/PostDaoRxJavaTest.kt

@@ -6,7 +6,7 @@ import org.junit.runners.Suite
 // Runs all unit tests with JUnit4.
 @RunWith(Suite::class)
 @Suite.SuiteClasses(
-    PostDaoCoroutinesCoroutinesFlowTest::class,
-    PostDaoCoroutinesRxJavaTest::class
+    PostDaoCoroutinesTest::class,
+    PostDaoRxJavaTest::class
 )
-class PostDaoCoroutinesTestSuite
+class PostDaoTestSuite

libraries/data/src/androidTest/java/com/smarttoolfactory/data/PostDaoCoroutinesTestSuite.kt renamed to libraries/data/src/androidTest/java/com/smarttoolfactory/data/PostDaoTestSuite.kt

@@ -5,7 +5,6 @@ import androidx.room.Delete
 import androidx.room.Insert
 import androidx.room.OnConflictStrategy
 import androidx.room.Query
-import androidx.room.Update
 import com.smarttoolfactory.data.model.PostEntity
 import io.reactivex.rxjava3.core.Completable
 import io.reactivex.rxjava3.core.Maybe
@@ -68,10 +67,4 @@ interface PostDaoRxJava3 {
 //     */
 //    @Query("SELECT * FROM post ORDER BY displayCount DESC")
 //    suspend fun getDisplayedMostPosts(): List<PostEntity>
-
-    /**
-     * Update a post's favorite or display count status.
-     */
-    @Update
-    fun updatePostFavoriteOrSelectStatus(postEntity: PostEntity)
 }

libraries/data/src/main/java/com/smarttoolfactory/data/db/PostDaoRxJava3.kt

@@ -28,6 +28,15 @@ data class PostEntity(
  *
  * * Status of the [PostEntity] with [PostEntity.id] or [PostStatus.postId] belong to current user
  * logged in with [PostStatus.userAccountId] or -1 if any user hasn't logged in
+ *
+ * * 🔥 Raw STATEMENT:  "CREATE TABLE IF NOT EXISTS `post_status`
+ *  (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL,
+ *  `userAccountId` INTEGER NOT NULL,
+ *  `postId` INTEGER NOT NULL,
+ *  `displayCount` INTEGER NOT NULL,
+ *  `isFavorite` INTEGER NOT NULL,
+ *  FOREIGN KEY(`postId`) REFERENCES `post`(`id`) ON UPDATE NO ACTION ON DELETE NO ACTION )"
+ *
  */
 @Entity(
     tableName = "post_status",

libraries/data/src/main/java/com/smarttoolfactory/data/model/PostEntity.kt

@@ -50,8 +50,6 @@ class GetPostListUseCaseFlowTest {
         @RegisterExtension
         val testCoroutineExtension = TestCoroutineExtension()
 
-        val testCoroutineScope = testCoroutineExtension.testCoroutineScope
-
         /*
             Mock Post data
          */