Skip to content

Create euclid.js #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Create euclid.js #1000

wants to merge 1 commit into from

Conversation

elfaidi-ghassen
Copy link

No description provided.

@Amaras
Copy link
Member

Amaras commented Jun 6, 2022

Hi!
Thank you for your first PR to the Algorithm Archive.
I am afraid we cannot consider your PR, as there already is a Euclidean algorithm JS implementation, and you didn't explicitly aim to improve it.
Furthermore, implementations files should be in the directory named after the language, so putting JavaScript code in the Factor directory is not the structure we are looking for.

For all these reasons, I have to close this PR immediately without review.
I hope you'll still want to improve the AAA further :)

@Amaras Amaras closed this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elfaidi-ghassen @Amaras