feat: add barman keep command #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Maslov <webconn@nebius.com>
webconn
force-pushed
the
feature/barman-keep-cmd
branch
from
395dd8a to
7ada087
Compare
webconn
added a commit
to webconn/cloudnative-pg
that referenced
this pull request
Mar 26, 2025
This patch adds `keep` option to backup spec and a reconsiler for it (currently only on backup creation stage, no post-backup changes). This option supports all possible `barman-cloud-backup-keep` modes: nokeep, standalone and full. This is a draft, it also requires merged changes in barman-cloud (cloudnative-pg/barman-cloud#97) and updated module version here afterwards. Signed-off-by: Nikita Maslov <webconn@nebius.com>
webconn
added a commit
to webconn/cloudnative-pg
that referenced
this pull request
May 6, 2025
This patch adds `keep` option to backup spec and a reconsiler for it (currently only on backup creation stage, no post-backup changes). This option supports all possible `barman-cloud-backup-keep` modes: nokeep, standalone and full. This is a draft, it also requires merged changes in barman-cloud (cloudnative-pg/barman-cloud#97) and updated module version here afterwards. Signed-off-by: Nikita Maslov <webconn@nebius.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a feature cloudnative-pg/cloudnative-pg#7181 (add keep target to backups), so I need a wrapper for
barman-cloud-backup-keepto call it from backup reconciler.This function is to be used in cloudnative-pg operator afterwards.