[WIP] Bump ruby_parser to 3.14.1
#353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larkinscott
commented
Jan 8, 2020
| @@ -140,6 +141,19 @@ def self.from_remediation_amount(amount) | |||
| expect(issues.length).to eq(3) | |||
| end | |||
|
|
|||
| it "parses modern (>2.6) Ruby syntax" do | |||
There was a problem hiding this comment.
This fails to parse before the parser version bump.
larkinscott
changed the title
ruby_parser to 3.14.1ruby_parser to 3.14.1 [WIP]
larkinscott
force-pushed
the
sl/bump-ruby-parser
branch
from
455a311 to
e5304be
Compare
This bumps `ruby_parser` to resolve an escalation with regards to how the duplication engine handled some more modern Ruby syntax: https://github.com/codeclimate-support/quality/issues/12. This bump also exposes a bug that was introduced into how the parser handles heredocs, so marking a test that has become less-than-helpful due to that as pending.
larkinscott
force-pushed
the
sl/bump-ruby-parser
branch
from
e5304be to
3013a74
Compare
larkinscott
changed the title
ruby_parser to 3.14.1 [WIP]ruby_parser to 3.14.1
|
Closing this PR for now. Would like to get this updated to the latest version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should remain WIP for now. We discovered that this would introduce a few regressions re: line numbering after bumping
ruby_parser.