Skip to content

Remove PHP parser dependency #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions DEVELOPERS.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
# Developer notes

## Upgrading php parser

* install php
* `cd vendor/php-parser`
* edit composer.json to use the newer version
* install composer: `curl "https://getcomposer.org/installer" | php`
* update `composer.lock`: `php composer.phar update`
* `rm composer.phar`

## QA

There is an automated [QA tool](https://github.com/codeclimate/qm_qa) that can
Expand Down
5 changes: 1 addition & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,8 @@ RUN apt-get update && \
python2.7

COPY Gemfile* ./
COPY vendor/php-parser/composer* ./vendor/php-parser/

RUN bundle install --jobs 4 --quiet && \
composer install --no-interaction --quiet --working-dir ./vendor/php-parser

RUN bundle install --jobs 4 --quiet
COPY . ./
RUN chown -R app:app ./

Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -257,3 +257,5 @@ see [sexp_processor][sexp_processor], especially [sexp.rb][sexp.rb]
[exclude-files-engine]: https://docs.codeclimate.com/docs/excluding-files-and-folders#section-exclude-paths-for-specific-engines
[sexp_processor]: https://github.com/seattlerb/sexp_processor/
[sexp.rb]: https://github.com/seattlerb/sexp_processor/blob/master/lib/sexp.rb


2 changes: 0 additions & 2 deletions vendor/php-parser/.gitignore

This file was deleted.

30 changes: 0 additions & 30 deletions vendor/php-parser/README.md

This file was deleted.

5 changes: 0 additions & 5 deletions vendor/php-parser/composer.json

This file was deleted.

69 changes: 0 additions & 69 deletions vendor/php-parser/composer.lock

This file was deleted.

85 changes: 0 additions & 85 deletions vendor/php-parser/lib/PhpParser/Serializer/JSON.php

This file was deleted.

26 changes: 0 additions & 26 deletions vendor/php-parser/parser.php

This file was deleted.

54 changes: 0 additions & 54 deletions vendor/php-parser/test/run

This file was deleted.

7 changes: 0 additions & 7 deletions vendor/php-parser/test/test.php

This file was deleted.