Skip to content

Nginx Proxy Manager script injecting own linkΒ #5985

Open
@GeekJosh

Description

@GeekJosh

βœ… Have you read and understood the above guidelines?

yes

πŸ“œ What is the name of the script you are using?

Nginx Proxy Manager

πŸ“‚ What was the exact command used to execute the script?

bash -c "$(curl -fsSL https://raw.githubusercontent.com/community-scripts/ProxmoxVE/main/ct/nginxproxymanager.sh)"

βš™οΈ What settings are you using?

  • Default Settings
  • Advanced Settings

πŸ–₯️ Which Linux distribution are you using?

Debian 12

πŸ“ Provide a clear and concise description of the issue.

When installing Nginx Proxy Manager, the setup script intentionally modifies the source code to replace a link to the project's own GitHub repository with a link back to the PVE Community Scripts website.

You can see this on lines 88-89:

sed -i 's|"fork-me": ".*"|"fork-me": "Proxmox VE Helper-Scripts"|' frontend/js/i18n/messages.json
sed -i "s|https://github.com.*source=nginx-proxy-manager|https://helper-scripts.com|g" frontend/js/app/ui/footer/main.ejs

This does not cause an issue with the installation, but I strongly object to any script making unintentional modifications to the source code I am installing, especially for the purposes of advertising.

The PVE Community Scripts website has been an amazing resource for Proxmox users, but this leaves a sour taste and makes me question what other modifications you have been making that I haven't noticed.

πŸ”„ Steps to reproduce the issue.

Run the installation script (not actually necessary, you can see the modification I'm objecting to clearly in the script)

❌ Paste the full error output (if available).

No error, just an unwanted link in the footer of every page of Nginx Proxy Manager.

πŸ–ΌοΈ Additional context (optional).

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions