Skip to content

Incorrect CustomValidationAttribute remarks #3126

Open
@hrobertson

Description

@hrobertson

Content: https://docs.microsoft.com/en-us/dotnet/api/system.componentmodel.dataannotations.customvalidationattribute.method?view=netcore-2.2
Content source: xml/System.ComponentModel.DataAnnotations/CustomValidationAttribute.xml

The remarks for the Method property of CustomValidationAttribute incorrectly state that the specified method must return a Boolean and takes a ValidationResult out param. In .Net Core 2.2 at least, it must return a ValidationResult.

Maybe the signature is different in different languages?

Additionally, it would be preferable to have the valid signatures listed as code snippets rather than described in text.

Activity

added
untriagedNew issue has not been triaged by the area owner
on Sep 5, 2019
mairaw

mairaw commented on Sep 5, 2019

@mairaw
Contributor

Thank you for your feedback @hrobertson.

@lajones, @divega, @ajcvickers can you help with this issue? Are there differences in behavior between .NET Framework and .NET Core for this API? Thanks.

added
cross-platformIndicates issues or PRs that relate to content applicable to both Framework and Core.
waiting-on-feedbackIndicates PRs that are waiting for feedback from SMEs before they can be merged
and removed
untriagedNew issue has not been triaged by the area owner
on Sep 5, 2019
added
Pri3Indicates issues/PRs that are low priority
on Nov 11, 2020
added a commit that references this issue on Mar 29, 2024
de6f204
linked a pull request that will close this issue on Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Pri3Indicates issues/PRs that are low priorityarea-System.ComponentModel.DataAnnotationscross-platformIndicates issues or PRs that relate to content applicable to both Framework and Core.waiting-on-feedbackIndicates PRs that are waiting for feedback from SMEs before they can be merged

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @hrobertson@dotnet-bot@mairaw@PRMerger13

      Issue actions

        Incorrect CustomValidationAttribute remarks · Issue #3126 · dotnet/dotnet-api-docs