-
Notifications
You must be signed in to change notification settings - Fork 4.9k
URI template operators *
and **
do not match the *
character
#39168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
This was referenced Apr 17, 2025
We should at least clarify this in docs. |
yanavlasov
pushed a commit
to yanavlasov/envoy
that referenced
this issue
May 5, 2025
…ewrite and matching (envoyproxy#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: envoyproxy#39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: envoyproxy#39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com>
yanavlasov
pushed a commit
to yanavlasov/envoy
that referenced
this issue
May 5, 2025
…ewrite and matching (envoyproxy#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: envoyproxy#39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: envoyproxy#39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
pushed a commit
to yanavlasov/envoy
that referenced
this issue
May 5, 2025
…ewrite and matching (envoyproxy#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: envoyproxy#39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: envoyproxy#39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
pushed a commit
to yanavlasov/envoy
that referenced
this issue
May 5, 2025
…ewrite and matching (envoyproxy#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: envoyproxy#39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: envoyproxy#39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
pushed a commit
to yanavlasov/envoy
that referenced
this issue
May 5, 2025
…ewrite and matching (envoyproxy#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: envoyproxy#39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: envoyproxy#39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
pushed a commit
to yanavlasov/envoy
that referenced
this issue
May 5, 2025
…ewrite and matching (envoyproxy#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: envoyproxy#39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: envoyproxy#39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
that referenced
this issue
May 5, 2025
…ewrite and matching (#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: #39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: #39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
that referenced
this issue
May 5, 2025
…ewrite and matching (#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: #39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: #39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
that referenced
this issue
May 6, 2025
…ewrite and matching (#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: #39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: #39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
that referenced
this issue
May 6, 2025
…ewrite and matching (#39169) Adds support for matching requests that include the `*` character in the path. A relevant issue was created: #39168 Risk Level: Testing: Updated unit tests Docs Changes: N/A Release Notes: Added Platform Specific Features: N/A Runtime guard: envoy.reloadable_features.uri_template_match_on_asterisk Resolves: #39168 --------- Signed-off-by: Chwila <bartosz.chwila@sap.com> Signed-off-by: Yan Avlasov <yavlasov@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Description:
When using the
*
or**
operators in URI template path, the templates do not match the*
operator. This behaviour is not documented, even though it is explicitly set up in this way according toenvoy/source/extensions/path/uri_template_lib/uri_template_internal.cc
Line 45 in 35d358e
Repro steps:
**
operator: e.g./anything/**
/anything/*abc
are not accepted.For example, reproducing using Istio, with following Envoy config setup for authorization:
Config:
References
The text was updated successfully, but these errors were encountered: