Update QUICHE from cfe837e35 to faec20635 #39189
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/google/quiche/compare/cfe837e35..faec20635 ``` $ git log cfe837e35..faec20635 --date=short --no-merges --format="%ad %al %s" 2025-04-18 martinduke No public description 2025-04-17 vasilvv Add an end-to-end test for WebTransport subprotocol negotiation. 2025-04-15 davidben Remove now unnecessary BORINGSSL_API_VERSION ifdefs ``` Signed-off-by: Ali Beyad <abeyad@google.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
/assign @phlax |
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
abeyad
added a commit
to abeyad/envoy
that referenced
this pull request
Apr 22, 2025
Previously, we temporarily reduced the coverage to 93.1% due to a drop explained in envoyproxy#39076. PR envoyproxy#39078 fixed the issue and put the coverage back to 93.2%, though the coverage check would still periodically fail. Updating to the latest QUICHE (envoyproxy#39189) is causing the Envoy/Checks to consistently fail with 93.1%, e.g. https://github.com/envoyproxy/envoy/actions/runs/14576448770/job/40947040997. Looking at the QUICHE diff, perhaps it's introduced by the new QUICHE flag added in the diff. It's hard to figure out how to improve the coverage at this point, so lowering to 93.1%. Signed-off-by: Ali Beyad <abeyad@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/google/quiche/compare/cfe837e35..faec20635