Skip to content

context: replace transport socket context with generic context #39201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

wbpcode
Copy link
Member

@wbpcode wbpcode commented Apr 22, 2025

Commit Message: context: replace transport socket context with generic context

Additional Description:

Now the transport factory context share same interface with generic context. We removed the transport socket factory context and use generic factory context as althernative.

This PR:

  1. removed TransportSocketFactoryContext and implementation.
  2. replaced all TransportSocketFactoryContext with GenericFactoryContext.
  3. Unified scope() to statsScope(). (The original TransportSocketFactoryContext use the statsScope(), but GenericFactoryContext use the scope(), this PR change all to statsScope())

Risk Level: low. mainly simple symbol replacement.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

Copy link

CC @envoyproxy/coverage-shephards: FYI only for changes made to (test/per_file_coverage.sh).
envoyproxy/coverage-shephards assignee is @RyanTheOptimist

🐱

Caused by: #39201 was opened by wbpcode.

see: more, trace.

Signed-off-by: wangbaiping(wbpcode) <wbphub@gmail.com>
@wbpcode wbpcode force-pushed the dev-transport-socket-factory-context branch from 07711f9 to ce6c508 Compare April 22, 2025 14:40
@wbpcode wbpcode marked this pull request as draft April 22, 2025 17:42
@wbpcode wbpcode closed this Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants