can guid impl be changed?

[websvcPT]

Hi there,
While testing fastapi-users [sqlalchemy] along with sqladmin I bumped on this

  File "/mnt/1T/work/user-management/.venv/lib/python3.8/site-packages/sqladmin/forms.py", line 78, in get_converter
    raise Exception(  # pragma: nocover
Exception: Could not find field converter for column id (<class 'fastapi_users_db_sqlalchemy.guid.GUID'>).

I understand that sqladmin does not know how to handle this since it does not have converter for UUIDChar (https://github.com/aminalaee/sqladmin/blob/main/sqladmin/forms.py#L78). It does handle UUID though.

This is provoqued by the following line at fastapi-users-db-sqlalchemy/

fastapi-users-db-sqlalchemy/fastapi_users_db_sqlalchemy/guid.py

Line 18 in 3e53775

impl = UUIDChar

.venv/lib/python3.8/site-packages/fastapi_users_db_sqlalchemy/guid.py

Is impl = UUIDChar a "standard" implementation or it should be named impl = UUID instead?

Otherwise, any way can I overwrite this?

[frankie567]

Actually, UUIDChar is defined just above. The rationale about why it's like this is here: fastapi-users/fastapi-users#646 In a nutshell, some libraries need to have the python_type explicitly defined to work.

I think it's more an issue on sqladmin side: overloading an impl is quite common and I believe they should support this case. For example, on pydantic-sqlalchemy, they take care of looking for a python_type everywhere: https://github.com/tiangolo/pydantic-sqlalchemy/blob/8667e213a6ad8e62288fad2a6621958e8ab0b688/pydantic_sqlalchemy/main.py#L25-L29

[websvcPT]

Thanks for your clarification @frankie567 🤘