Skip to content

Add --branch argument to print_github_reviews.py #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025

Conversation

jonsimantov
Copy link
Contributor

This change allows the script to find a pull request based on a specified branch name, in addition to the existing methods of using a pull request number or the current git branch.

The --branch argument is mutually exclusive with --pull_number. If neither --pull_number nor --branch is provided, the script defaults to finding the latest PR for the current git branch.

Description

Provide details of the change, and generalize the change in the PR title above.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

This change allows the script to find a pull request based on a specified branch name, in addition to the existing methods of using a pull request number or the current git branch.

The --branch argument is mutually exclusive with --pull_number.
If neither --pull_number nor --branch is provided, the script defaults to finding the latest PR for the current git branch.
@jonsimantov jonsimantov marked this pull request as ready for review June 27, 2025 18:16
@jonsimantov jonsimantov merged commit e9ab71d into main Jun 27, 2025
27 of 28 checks passed
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jun 27, 2025
Copy link

github-actions bot commented Jun 27, 2025

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit e9ab71d
Last updated: Fri Jun 27 13:12 PDT 2025
View integration test log & download artifacts

Failures Configs
auth [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseAuthTest.TestEmailAndPasswordSignin
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jun 27, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant