Fix build status report #1764
Merged
Fix build status report #1764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented exponential backoff and increased retries for API requests in `firebase_github.py`. - Added specific handling for 410 errors when downloading artifacts, preventing retries for expired artifacts. - Updated `report_build_status.py` to prioritize newer artifacts and added timeouts for downloads. - Ensured the script falls back to reading GitHub logs if artifacts cannot be downloaded. - Addressed missing dependencies: `python-dateutil`, `progress`, and `attrs`. - Corrected the `--verbosity` flag usage.
Introduced two new environment variables in `integration_tests.yml`: - `logArtifactRetentionDays` set to 90 days for log artifacts. - `binaryArtifactRetentionDays` set to 7 days for binary artifacts (test apps, videos, etc.). Updated all `actions/upload-artifact` steps to use the corresponding environment variable for `retention-days` based on the type of artifact being uploaded. (Previous commit used snake_case; this commit corrects to camelCase for consistency with existing `artifactRetentionDays` variable.)
a-maurice
approved these changes
Jul 1, 2025
scripts/gha/firebase_github.py
Outdated
| @@ -57,13 +57,15 @@ def set_repo_url(repo): | |||
|
|
|||
| def requests_retry_session(retries=RETRIES, | |||
| backoff_factor=BACKOFF, | |||
| status_forcelist=RETRY_STATUS): | |||
| status_forcelist=RETRY_STATUS, | |||
| allowed_methods=frozenset(['GET', 'POST', 'PUT', 'DELETE', 'PATCH'])): # Added allowed_methods | |||
scripts/gha/firebase_github.py
Outdated
| session = requests.Session() | ||
| retry = Retry(total=retries, | ||
| read=retries, | ||
| connect=retries, | ||
| backoff_factor=backoff_factor, | ||
| status_forcelist=status_forcelist) | ||
| status_forcelist=status_forcelist, | ||
| allowed_methods=allowed_methods) # Added allowed_methods |
Removed comments related to `allowed_methods` as they were deemed unnecessary.
Removed comments related to `allowed_methods` as they were deemed unnecessary.
github-actions
bot
added
the
tests: in-progress
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit fb725e9
Add flaky tests to go/fpl-cpp-flake-tracker |
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle 401 Gone errors, and also increase retention time so logs last 90 days.
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.