Resolve android corrupted recordings #1836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniel-g-favoreto-opl @bantunes22. @cloudwebrtc |
jawad1257
force-pushed
the
resolved-android-corrupted-recordings
branch
from
630ad4b to
ecade84
Compare
|
hey @jawad1257 , The code modification looks good, but can you please remove the license at the top of the code line? Generally speaking, when you create a PR, it means that you contribute this PR to flutter-webrtc and will follow the MIT license to share the modification with everyone else. and your changes will be recorded in the PR or new version CHANGELOG. |
jawad1257
force-pushed
the
resolved-android-corrupted-recordings
branch
from
ecade84 to
eb6cd21
Compare
|
@cloudwebrtc i was able to condense it down to one line. But because of the MIT we need to add this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current stop function does not wait for the recording process to fully stop before proceeding. This can lead to corrupted files, as the audio or video thread may still be accessing the file when the app attempts to move it to the user's Movies directory. This MR updates the stop function to ensure it waits for the recording to completely stop, preventing file corruption.