New Node.JS Otel samples #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One comment that needs to be dealt with here and any other repo that uses Docker - you should not be pulling containers from dockerhub. That's essentially banned from within IBM. So, for example, prometheus can come instead from |
For this pull request the source registries for the Node.js, Jaeger and Prometheus containers have been updated. |
rcoppen
requested changes
Jun 25, 2025
Node.js-OTel/README.md
Outdated
| ### Running the sample application | ||
| The application can be started in one of three modes | ||
|
|
||
| - `npm run start` which starts up the application without any instrumentation |
Co-authored-by: Richard Coppen <30902631+rcoppen@users.noreply.github.com>
Co-authored-by: Richard Coppen <30902631+rcoppen@users.noreply.github.com>
Co-authored-by: Richard Coppen <30902631+rcoppen@users.noreply.github.com>
Co-authored-by: Richard Coppen <30902631+rcoppen@users.noreply.github.com>
rcoppen
approved these changes
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP triggered MQI PUT and GET processes sprinkled with Open Telemetry instrumentation.