Skip to content

minikube-ingress-dns addons using two different images? #20629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
medyagh opened this issue Apr 15, 2025 · 3 comments
Open

minikube-ingress-dns addons using two different images? #20629

medyagh opened this issue Apr 15, 2025 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@medyagh
Copy link
Member

medyagh commented Apr 15, 2025

in the code I see

		"IngressDNS": "k8s-minikube/minikube-ingress-dns:0.0.3@sha256:4211a1de532376c881851542238121b26792225faa36a7b02dccad88fd05797c",
	}, map[string]string{
		"IngressDNS": "gcr.io",
	}),

also I see

				"IngressDNS": "cryptexlabs/minikube-ingress-dns:0.3.0@sha256:e252d2a4c704027342b303cc563e95d2e71d2a0f1404f55d676390e28d5093ab",
		}

I suspect maybe the cryptexlabs/minikube-ingress-dns is the one that neeeds to go

I beleive @sharifelgamal had a fork of this, do you remember that ?

@medyagh medyagh added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 15, 2025
@medyagh
Copy link
Member Author

medyagh commented Apr 15, 2025

Found the fork but now we need to find a way to build the image https://github.com/sharifelgamal/minikube-ingress-dns

@woodcockjosh are you still around would you like to refresh the image it is very outdated and needs bump of libs

@medyagh
Copy link
Member Author

medyagh commented Apr 15, 2025

here is the code that builds the image
https://github.com/sharifelgamal/minikube-ingress-dns/blob/main/app/dns-server/bin/build-deploy.sh

@ComradeProgrammer could we try to bump the base image and libs in that repo (we can make a PR and sharif might be able to merge it for us)

@woodcockjosh
Copy link
Contributor

https://gitlab.com/cryptexlabs/public/development/minikube-ingress-dns

Please open an MR while I have my attention in focus on this. Will get it merged and built before Monday next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

2 participants