Skip to content

Added Pumble Notification #5781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2025
Merged

Added Pumble Notification #5781

merged 3 commits into from
Apr 26, 2025

Conversation

cs-jako
Copy link
Contributor

@cs-jako cs-jako commented Apr 16, 2025

⚠️ Please Note: We do not accept all types of pull requests, and we want to ensure we don’t waste your time. Before submitting, make sure you have read our pull request guidelines: Pull Request Rules

❗ Important Announcement

Click here for more details:

🚧 Temporary Delay in Feature Requests and Pull Request Reviews

At this time, we may be slower to respond to new feature requests and review pull requests. Existing requests and PRs will remain in the backlog but may not be prioritized immediately.

  • Reason: Our current focus is on addressing bugs, improving system performance, and implementing essential updates. This will help stabilize the project and ensure smoother management.
  • Impact: While no new feature requests or pull requests are being outright rejected, there may be significant delays in reviews. We encourage the community to help by reviewing PRs or assisting other users in the meantime.
  • What You Can Do: If you're interested in contributing, reviewing open PRs by following our Review Guidelines or offering support to other users is greatly appreciated. All feature requests and PRs will be revisited once the suspension period is lifted.

We appreciate your patience and understanding as we continue to improve Uptime Kuma.

🚫 Please Avoid Unnecessary Pinging of Maintainers

We kindly ask you to refrain from pinging maintainers unless absolutely necessary. Pings are reserved for critical/urgent pull requests that require immediate attention.

Why: Reserving pings for urgent matters ensures maintainers can prioritize critical tasks effectively.

📋 Overview

Provide a clear summary of the purpose and scope of this pull request:

  • What problem does this pull request address?

    • Please provide a detailed explanation here.
  • What features or functionality does this pull request introduce or enhance?

    • Please provide a detailed explanation here.

🔄 Changes

🛠️ Type of change

  • 🐛 Bugfix (a non-breaking change that resolves an issue)
  • ✨ New feature (a non-breaking change that adds new functionality): Notification Provider
  • ⚠️ Breaking change (a fix or feature that alters existing functionality in a way that could cause issues)
  • 🎨 User Interface (UI) updates
  • 📄 New Documentation (addition of new documentation)
  • 📄 Documentation Update (modification of existing documentation)
  • 📄 Documentation Update Required (the change requires updates to related documentation)
  • 🔧 Other (please specify):
    • Provide additional details here.

🔗 Related Issues

  • Relates to #issue-number
  • Resolves #issue-number
  • Fixes #issue-number

📄 Checklist *

  • 🔍 My code adheres to the style guidelines of this project.
  • ✅ I ran ESLint and other code linters for modified files.
  • 🛠️ I have reviewed and tested my code.
  • 📝 I have commented my code, especially in hard-to-understand areas (e.g., using JSDoc for methods).
  • ⚠️ My changes generate no new warnings.
  • 🤖 My code needed automated testing. I have added them (this is an optional task).
  • 📄 Documentation updates are included (if applicable).
  • 🔒 I have considered potential security impacts and mitigated risks.
  • 🧰 Dependency updates are listed and explained.
  • 📚 I have read and understood the Pull Request guidelines.

📷 Screenshots or Visual Changes

  • UI Modifications: Highlight any changes made to the user interface.
  • Before & After: Include screenshots or comparisons (if applicable).
Event Before
UP image
DOWN image
Certificate-expiry image
Testing image

ℹ️ Additional Context

Provide any relevant details to assist reviewers in understanding the changes.

Click here for more details: This is related to my previous pull request (5342) which I closed after some time of inactivity.

Key Considerations:

  • Design decisions – Key choices or trade-offs made during development.
  • Alternative solutions – Approaches considered but not implemented, along with reasons.
  • Relevant links – Specifications, discussions, or resources that provide context.
  • Dependencies – Related pull requests or issues that must be resolved before merging.
  • Additional context – Any other details that may help reviewers understand the changes.

Provide details here

💬 Requested Feedback

  • Mention documents needing feedback here

@cs-jako cs-jako mentioned this pull request Apr 16, 2025
7 tasks
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

Will merge into 2.1 once we branch into that direction, until then, will leave this open.
Please don't delete your repo, even if this takes a while, that closes this PR.

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Apr 16, 2025
@CommanderStorm CommanderStorm added A:notifications Issues or PRs related to notifications type:new proposing to add a new monitor pr:depends on other pending other things to be done first labels Apr 16, 2025
@cs-jako
Copy link
Contributor Author

cs-jako commented Apr 17, 2025

Thank you!

@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0-beta.3 Apr 26, 2025
@CommanderStorm
Copy link
Collaborator

Moving from 2.1 to 2.0.0-beta.3 as really low risk

@CommanderStorm CommanderStorm merged commit 33f253f into louislam:master Apr 26, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:notifications Issues or PRs related to notifications pr:depends on other pending other things to be done first type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants