ServicingPipeline: make a bunch of quality of life improvements #18830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to cherry-pick every commit that had even one card in "To Cherry Pick", even if it was also referenced by a card in "Rejected" or even "To Consider". Now we will warn and skip those commits. I took this opportunity to add a bit of an object model for servicing cards as well.
|
|
|
The colors match the ones in the project board (woo) |
DHowett
changed the title
BoomchainLabs
approved these changes
Apr 24, 2025
lhecker
approved these changes
Apr 24, 2025
DHowett
added a commit
that referenced
this pull request
Apr 24, 2025
We used to cherry-pick every commit that had even one card in "To Cherry Pick", even if it was also referenced by a card in "Rejected" or even "To Consider". Now we will warn and skip those commits. I took this opportunity to add a bit of an object model for servicing cards as well as prettify the output. That allowed us to add a list of cards that were ignored due to having no commits, and display little icons for each type of card. (cherry picked from commit 8e94983) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgZtprA Service-Version: 1.22
DHowett
added a commit
that referenced
this pull request
Apr 24, 2025
We used to cherry-pick every commit that had even one card in "To Cherry Pick", even if it was also referenced by a card in "Rejected" or even "To Consider". Now we will warn and skip those commits. I took this opportunity to add a bit of an object model for servicing cards as well as prettify the output. That allowed us to add a list of cards that were ignored due to having no commits, and display little icons for each type of card. (cherry picked from commit 8e94983) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgZtpq8 Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to cherry-pick every commit that had even one card in "To Cherry Pick", even if it was also referenced by a card in "Rejected" or even "To Consider".
Now we will warn and skip those commits.
I took this opportunity to add a bit of an object model for servicing cards as well as prettify the output.
That allowed us to add a list of cards that were ignored due to having no commits, and display little icons for each type of card.