fix: Support ruff 0.12 #1270

renovate · 2025-06-17T17:08:55Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
ruff (source, changelog)	`>=0.2,<0.12` -> `>=0.2,<0.13`

Release Notes

astral-sh/ruff (ruff)

`v0.12.0`

Compare Source

Check out the blog post for a migration
guide and overview of the changes!

Breaking changes

Detection of more syntax errors

Ruff now detects version-related syntax errors, such as the use of the match
statement on Python versions before 3.10, and syntax errors emitted by
CPython's compiler, such as irrefutable match patterns before the final
case arm.
New default Python version handling for syntax errors

Ruff will default to the latest supported Python version (3.13) when
checking for the version-related syntax errors mentioned above to prevent
false positives in projects without a Python version configured. The default
in all other cases, like applying lint rules, is unchanged and remains at the
minimum supported Python version (3.9).
Updated f-string formatting

Ruff now formats multi-line f-strings with format specifiers to avoid adding a
line break after the format specifier. This addresses a change to the Python
grammar in version 3.13.4 that made such a line break a syntax error.
rust-toolchain.toml is no longer included in source distributions

The rust-toolchain.toml is used to specify a higher Rust version than Ruff's
minimum supported Rust version (MSRV) for development and building release
artifacts. However, when present in source distributions, it would also cause
downstream package maintainers to pull in the same Rust toolchain, even if
their available toolchain was MSRV-compatible.

Removed Rules

The following rules have been removed:

suspicious-xmle-tree-usage
(S320)

Deprecated Rules

The following rules have been deprecated:

pandas-df-variable-name

Stabilization

The following rules have been stabilized and are no longer in preview:

for-loop-writes (FURB122)
check-and-remove-from-set (FURB132)
verbose-decimal-constructor (FURB157)
fromisoformat-replace-z (FURB162)
int-on-sliced-str (FURB166)
exc-info-outside-except-handler (LOG014)
import-outside-top-level (PLC0415)
unnecessary-dict-index-lookup (PLR1733)
nan-comparison (PLW0177)
eq-without-hash (PLW1641)
pytest-parameter-with-default-argument (PT028)
pytest-warns-too-broad (PT030)
pytest-warns-with-multiple-statements (PT031)
invalid-formatter-suppression-comment (RUF028)
dataclass-enum (RUF049)
class-with-mixed-type-vars (RUF053)
unnecessary-round (RUF057)
starmap-zip (RUF058)
non-pep604-annotation-optional (UP045)
non-pep695-generic-class (UP046)
non-pep695-generic-function (UP047)
private-type-parameter (UP049)

The following behaviors have been stabilized:

[collection-literal-concatenation] (RUF005) now recognizes slices, in
addition to list literals and variables.
The fix for [readlines-in-for] (FURB129) is now marked as always safe.
[if-else-block-instead-of-if-exp] (SIM108) will now further simplify
expressions to use or instead of an if expression, where possible.
[unused-noqa] (RUF100) now checks for file-level noqa comments as well
as inline comments.
[subprocess-without-shell-equals-true] (S603) now accepts literal strings,
as well as lists and tuples of literal strings, as trusted input.
[boolean-type-hint-positional-argument] (FBT001) now applies to types that
include bool, like bool | int or typing.Optional[bool], in addition to
plain bool annotations.
[non-pep604-annotation-union] (UP007) has now been split into two rules.
UP007 now applies only to typing.Union, while
[non-pep604-annotation-optional] (UP045) checks for use of
typing.Optional. UP045 has also been stabilized in this release, but you
may need to update existing include, ignore, or noqa settings to
accommodate this change.

Preview features

[ruff] Check for non-context-manager use of pytest.raises, pytest.warns, and pytest.deprecated_call (RUF061) (#17368)
[syntax-errors] Raise unsupported syntax error for template strings prior to Python 3.14 (#18664)

Bug fixes

Add syntax error when conversion flag does not immediately follow exclamation mark (#18706)
Add trailing space around readlines (#18542)
Fix \r and \r\n handling in t- and f-string debug texts (#18673)
Hug closing } when f-string expression has a format specifier (#18704)
[flake8-pyi] Avoid syntax error in the case of starred and keyword arguments (PYI059) (#18611)
[flake8-return] Fix RET504 autofix generating a syntax error (#18428)
[pep8-naming] Suppress fix for N804 and N805 if the recommended name is already used (#18472)
[pycodestyle] Avoid causing a syntax error in expressions spanning multiple lines (E731) (#18479)
[pyupgrade] Suppress UP008 if super is shadowed (#18688)
[refurb] Parenthesize lambda and ternary expressions (FURB122, FURB142) (#18592)
[ruff] Handle extra arguments to deque (RUF037) (#18614)
[ruff] Preserve parentheses around deque in fix for unnecessary-empty-iterable-within-deque-call (RUF037) (#18598)
[ruff] Validate arguments before offering a fix (RUF056) (#18631)
[ruff] Skip fix for RUF059 if dummy name is already bound (#18509)
[pylint] Fix PLW0128 to check assignment targets in square brackets and after asterisks (#18665)

Rule changes

Fix false positive on mutations in return statements (B909) (#18408)
Treat ty: comments as pragma comments (#18532)
[flake8-pyi] Apply custom-typevar-for-self to string annotations (PYI019) (#18311)
[pyupgrade] Don't offer a fix for Optional[None] (UP007, UP045) (#18545)
[pyupgrade] Fix super(__class__, self) detection (UP008) (#18478)
[refurb] Make the fix for FURB163 unsafe for log2, log10, *args, and deleted comments (#18645)

Server

Support cancellation requests (#18627)

Documentation

Drop confusing second * from glob pattern example for per-file-target-version (#18709)
Update Neovim configuration examples (#18491)
[pylint] De-emphasize __hash__ = Parent.__hash__ (PLW1641) (#18613)
[refurb] Add a note about float literal handling (FURB157) (#18615)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

johnthagen · 2025-06-17T18:41:47Z

Would ❤️ a release with this PR in it. 😄

johnthagen · 2025-06-17T18:43:19Z

Looks like CI failures are from

https://docs.astral.sh/ruff/rules/import-outside-top-level/

May want to disable this lint selectively.

renovate · 2025-06-19T02:12:21Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

dbanty · 2025-06-19T02:41:09Z

So mypy is just failing on Windows for some reason? And I don't think it's the changes here because #1268 is failing too 😞.

johnthagen · 2025-06-19T11:11:37Z

Maybe unrelated but perhaps the PDM configuration/lockfile for this project also has issues?

Check out the Install Dependencies step

https://github.com/openapi-generators/openapi-python-client/actions/runs/15713687555/job/44278018995

pdm install
  shell: /bin/bash -e {0}
  env:
    pythonLocation: /Users/runner/hostedtoolcache/Python/[3](https://github.com/openapi-generators/openapi-python-client/actions/runs/15713687555/job/44278018995#step:7:3).13.4/arm64
    PKG_CONFIG_PATH: /Users/runner/hostedtoolcache/Python/3.13.[4](https://github.com/openapi-generators/openapi-python-client/actions/runs/15713687555/job/44278018995#step:7:4)/arm64/lib/pkgconfig
    Python_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.13.4/arm[6](https://github.com/openapi-generators/openapi-python-client/actions/runs/15713687555/job/44278018995#step:7:6)4
    Python2_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.13.4/arm64
    Python3_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.13.4/arm64
WARNING: Project requires a python version of <4.0,>=3.9, The virtualenv is being created for you as it cannot be matched to the right version.

johnthagen · 2025-06-19T11:40:30Z

We are currently installing

  ✔ Install mypy 1.16.0 successful

But 1.16.1 is out. Perhaps it's worth seeing if 1.16.1 fixed the issue?

https://pypi.org/project/mypy/1.16.1/

dbanty · 2025-06-19T15:02:48Z

Looks like updating worked, thanks!

> [!IMPORTANT] > Merging this pull request will create this release ## Fixes - Support ruff 0.12 (#1270) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>

chore(deps): update dependency ruff to >=0.2,<0.13

aca2732

dbanty added 2 commits June 18, 2025 20:08

Address new Ruff lints

1fa7e97

Don't run old linters on generator when testing min deps

9f3a625

Merge branch 'main' into renovate/ruff-0.x

be43d1d

dbanty changed the title ~~chore(deps): update dependency ruff to >=0.2,<0.13~~ chore(deps): update dependency ruff to >0.12 Jun 19, 2025

dbanty changed the title ~~chore(deps): update dependency ruff to >0.12~~ fix: Support ruff 0.12 Jun 19, 2025

dbanty approved these changes Jun 19, 2025

View reviewed changes

dbanty added this pull request to the merge queue Jun 19, 2025

Merged via the queue into main with commit ddad859 Jun 19, 2025
22 checks passed

dbanty deleted the renovate/ruff-0.x branch June 19, 2025 15:06

knope-bot bot mentioned this pull request Jun 19, 2025

Release 0.25.1 #1273

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: Support ruff 0.12 #1270

fix: Support ruff 0.12 #1270

Uh oh!

renovate bot commented Jun 17, 2025

Uh oh!

johnthagen commented Jun 17, 2025

Uh oh!

johnthagen commented Jun 17, 2025

Uh oh!

renovate bot commented Jun 19, 2025

Uh oh!

dbanty commented Jun 19, 2025

Uh oh!

johnthagen commented Jun 19, 2025

Uh oh!

johnthagen commented Jun 19, 2025

Uh oh!

dbanty commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: Support ruff 0.12 #1270

fix: Support ruff 0.12 #1270

Uh oh!

Conversation

renovate bot commented Jun 17, 2025

Release Notes

v0.12.0

Breaking changes

Removed Rules

Deprecated Rules

Stabilization

Preview features

Bug fixes

Rule changes

Server

Documentation

Configuration

Uh oh!

johnthagen commented Jun 17, 2025

Uh oh!

johnthagen commented Jun 17, 2025

Uh oh!

renovate bot commented Jun 19, 2025

Edited/Blocked Notification

Uh oh!

dbanty commented Jun 19, 2025

Uh oh!

johnthagen commented Jun 19, 2025

Uh oh!

johnthagen commented Jun 19, 2025

Uh oh!

dbanty commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

`v0.12.0`