fix for building docs on Windows #61686
Merged
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Jun 22, 2025
| @@ -83,7 +83,7 @@ using the `prun ipython magic function <https://ipython.readthedocs.io/en/stable | |||
| .. ipython:: python | |||
|
|
|||
| # most time consuming 4 calls | |||
| %prun -l 4 df.apply(lambda x: integrate_f(x["a"], x["b"], x["N"]), axis=1) # noqa E999 | |||
| %prun -l 4 df.apply(lambda x: integrate_f(x['a'], x['b'], x['N']), axis=1) # noqa E999 | |||
There was a problem hiding this comment.
E999 has been removed. Remove the comment?
| @@ -204,7 +204,7 @@ calls are needed to utilize this function. | |||
|
|
|||
| .. ipython:: python | |||
|
|
|||
| %timeit apply_integrate_f(df["a"].to_numpy(), df["b"].to_numpy(), df["N"].to_numpy()) | |||
| %timeit apply_integrate_f(df['a'].to_numpy(), df['b'].to_numpy(), df['N'].astype(int).to_numpy()) | |||
There was a problem hiding this comment.
Can you instead create this as a 64-bit on L53 above?
"N": np.random.randint(100, 1000, (1000), dtype="int64"),
|
Thanks @Dr-Irv |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc\source\user_guide\enhancingperf.rst) #60149I was having two issues with building the docs on Windows.
--singlewas very slow because it was reading in lots of files. So there is a fix inconf.pythat changes any backslashes to/in the paths. Probably a better fix is to not be usingos.joinand usepathlib, but that's a larger change.doc\source\user_guide\enhancingperf.rst) #60149, there are 2 issues with buildingenhancingperf.rst:doc\source\user_guide\enhancingperf.rst) #60149 (comment) , having double quotes in the ipython strings messes up Windows, so changing them to single quotes makes it workint64dtypes, but the defaults coming fromnumpywhen building the DF areint32, so theastype(int)calls fix that