Closed
Description
| Q | A |
|---|---|
| Bug? | maybe |
| New Feature? | maybe |
| Version | 1.2.0 |
Actual Behavior
Package does provide only php-http/client-implementation
Expected Behavior
Package should also provide psr/http-client-implementation if fully compatible with PSR-18
Steps to Reproduce
Create a project with composer.json:
...
"require": {
"psr/http-client": "^1.0.0",
"psr/http-client-implementation": "^1.0.0",
"psr/http-message": "^1.0.0",
"psr/http-message-implementation": "^1.0.0",
"psr/http-factory": "^1.0.0",
"psr/http-factory-implementation": "^1.0.0",
},
"require-dev": {
"phpunit/phpunit": "^6.0.0",
"nyholm/psr7": "^1.0.0",
"php-http/mock-client": "^1.2.0"
},
...Composer install/update will fail with Your requirements could not be resolved to an installable set of packages. where it would succeed if I'd require php-http/client-implementation instead.
Possible Solutions
Add psr/http-client-implementation to composer.json provides section.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Participants
Activity
xabbuh commentedon Feb 6, 2019
So far this looks expected to me. The
Clientclass does implement theHttpClientinterface only and this interface is only PSR-18 compatible if HTTPlug 2 is installed (but the mock client works with HTTPlug 1 too).dbu commentedon Feb 21, 2019
i agree with xabbuh on this. anyways it feels dangerous when this package "provides" the client implementation - a real project should always also have an actual implementation and only use the mock client for testing.
or am i missing a use case here? i guess libraries with no functional tests would be one... but until we require httplug 2 we should not claim that we are psr-18 when we can't guarantee that.
powli commentedon Feb 22, 2019
I have to agree, I was missing the hold compatibility with HTTPlug 1. So maybe a version 2.0 that only depends on HTTPlung 2 would make sense.
That's in fact exactly our use case. We have a library and just want to say: 'Throw any compatible client into the project and it will work'. For tests we only use recorded requests/responses from the wrapped API.
dbu commentedon Feb 23, 2019
i added this to #34
there are however no immediate plans to go release mock client 2.0. if you want to do a pull request against the branch we use in #34 i can see moving this forward however. the mock-client seems reasonably stable, version 1 will remain just usable for existing libraries that still allow httplug 1.
dbu commentedon Jul 2, 2020
this will happen in version 2, with #34