Dmius repgen 86 #100

dmius · 2018-11-30T07:42:35Z

No description provided.

Nastradamus · 2018-11-30T08:43:56Z

I fixed Makefile to fix build on any supported by golang OS'es.

Nastradamus · 2018-11-30T09:01:20Z

After first run, I see several issues:

Relative UNIX path is not supported (existing file not found)
The program continues to run after an error
UNIX-like file path'es not supported
Error Data file or template is wrong while report is correct
DEBUG messages apper while I did not turnet on any debug options
--checkdata expects data if can't find a file
Cannot find and load plugin. appears in STDOUT (STDERR expected)

[vyagofarov@mac:~/git/healthcheck] $ ./pghrep/bin/pghrep --checkdata=./artifacts/dummy/1_2018_11_30T11_23_03_+0300/A005_extensions.json
2018/11/30 11:24:05 ERROR: File given by --checkdata not found, will used as json data ./artifacts/dummy/1_2018_11_30T11_23_03_+0300/A005_extensions.json
2018/11/30 11:24:05 >>> DEBUG:  Can't parse json data: invalid character '.' looking for beginning of value
2018/11/30 11:24:05 ERROR: Content given by --checkdata is wrong json content.

[vyagofarov@mac:~/git/healthcheck] $ ./pghrep/bin/pghrep --checkdata=/Users/vyagofarov/git/healthcheck/artifacts/dummy/1_2018_11_30T11_23_03_+0300/A005_extensions.json
2018/11/30 11:48:00 ERROR: File given by --checkdata not found, will used as json data /Users/vyagofarov/git/healthcheck/artifacts/dummy/1_2018_11_30T11_23_03_+0300/A005_extensions.json
2018/11/30 11:48:00 >>> DEBUG:  Can't parse json data: invalid character '/' looking for beginning of value
2018/11/30 11:48:00 ERROR: Content given by --checkdata is wrong json content.
[vyagofarov@mac:~/git/healthcheck] $

[vyagofarov@mac:~/git/healthcheck] $ ./pghrep/bin/pghrep --checkdata=file:///Users/vyagofarov/git/healthcheck/artifacts/dummy/1_2018_11_30T11_23_03_+0300/A005_extensions.json
2018/11/30 11:49:18 >>> DEBUG:  File path /Users/vyagofarov/git/healthcheck/artifacts/dummy/1_2018_11_30T11_23_03_+0300/A005_extensions.json
2018/11/30 11:49:18 >>> DEBUG:  File path /Users/vyagofarov/git/healthcheck/artifacts/dummy/1_2018_11_30T11_23_03_+0300/A005_extensions.json
2018/11/30 11:49:18 >>> DEBUG:  Replicas map[]
2018/11/30 11:49:18 >>> DEBUG:  Hosts map[replicas:[] master:dev]
2018/11/30 11:49:18 WARNING: Plugin /Users/vyagofarov/git/healthcheck/bin/A005.so not found.
Cannot find and load plugin. stat /Users/vyagofarov/git/healthcheck/plugins/A005.go: no such file or directory
2018/11/30 11:49:18 >>> DEBUG:  Find A005.tpl
2018/11/30 11:49:18 >>> DEBUG:  reportTpl <nil>
2018/11/30 11:49:18 Cannot generate report. Data file or template is wrong.

dmius · 2018-11-30T10:48:23Z

1 Now supported only filepath with file:// prefix, relative and absoulute
2 Will fixed in next commit
3 See 1
4 Now exists only A001 and A002 templates
5 Will fixed in next commit
6 Will fixed in next commit
7 Will enabled in debug mode only, plugin not required for every report, so this just information message.

NikolayS · 2018-12-03T05:49:32Z

pghrep/README.md

@@ -0,0 +1,5 @@
+For generate report use:


"To generate ..."

NikolayS · 2018-12-03T06:43:54Z

pghrep/README.md

+
+`./bin/pghrep --checkdata=file:///path_to_json_repots_storage/A002_pgversion.json --outdir=/path_to_md_reports_storage/ `
+
+also for enable debug mode add option `--debug 1`


also, to enable debug mode, use --debug 1

NikolayS · 2018-12-03T06:44:17Z

pghrep/src/main.go

-/* 2018 © Dmitry Udalov dmius@postgres.ai
- 2018 © Postgres.ai
+/*
+Postgres Healt Reporter


NikolayS · 2018-12-03T06:45:43Z

pghrep/src/main.go

+    }
+}
+
+func determineMasterReplica(data map[string]interface{}) {


давай комментарии к функции распишем.

из названия совершенно непонятно, что она делает — определяет, мастер это или реплика? или что? (возможно, название тоже стоит улучшить)

pghrep/src/main.go

NikolayS · 2018-12-03T08:23:23Z

The code works as expected, let's do these two corrections, as discussed:

get rid of file:// completely
allow use of both absolute (/path/to/file/or/dir) and relative (./path/to or path/to) paths to files/directories in any parameter

Nastradamus

Good! It works in macOS. Generated report A001:

[vyagofarov@mac:~/git/healthcheck/pghrep] $ ./bin/pghrep -checkdata=./artifacts/dummy/1_2018_11_30T18_02_12_+0300/A005_extensions.json

dmius and others added 4 commits November 29, 2018 16:08

Not need plugin for every report, a002 template added

c964135

checkid param removed, A001 report added

59f12be

remove unneed plugin

e665675

refactor Makefile and add posibility to build on all OS'es

e24407d

Nastradamus mentioned this pull request Nov 30, 2018

Get all .md reports at once #85

Closed

dmius added 3 commits November 30, 2018 15:11

A003 template

adb53ad

A004, A005, A006 templates added

6dfa323

Merge branch 'master' into dmius-repgen-86

ba982c9

NikolayS reviewed Dec 3, 2018

View reviewed changes

pghrep/README.md Outdated

@@ -0,0 +1,5 @@

For generate report use:

Copy link

Collaborator

NikolayS Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"To generate ..."

NikolayS reviewed Dec 3, 2018

View reviewed changes

pghrep/src/main.go

/* 2018 © Dmitry Udalov dmius@postgres.ai

2018 © Postgres.ai

/*

Postgres Healt Reporter

Copy link

Collaborator

NikolayS Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Health

NikolayS reviewed Dec 3, 2018

View reviewed changes

pghrep/src/main.go Show resolved Hide resolved

dmius added 2 commits December 3, 2018 14:17

Process paths reworked

157677e

A006 plugin and template added

a27cbd0

Nastradamus approved these changes Dec 4, 2018

View reviewed changes

dmius merged commit 28c5885 into master Dec 4, 2018

NikolayS deleted the dmius-repgen-86 branch December 5, 2018 05:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dmius repgen 86 #100

Dmius repgen 86 #100

Uh oh!

dmius commented Nov 30, 2018

Uh oh!

Nastradamus commented Nov 30, 2018

Uh oh!

Nastradamus commented Nov 30, 2018

Uh oh!

dmius commented Nov 30, 2018

Uh oh!

NikolayS Dec 3, 2018

Uh oh!

NikolayS Dec 3, 2018

Uh oh!

NikolayS Dec 3, 2018

Uh oh!

NikolayS Dec 3, 2018 •

edited

Loading

Uh oh!

Uh oh!

NikolayS commented Dec 3, 2018 •

edited

Loading

Uh oh!

Nastradamus left a comment

Uh oh!

Uh oh!


		`./bin/pghrep --checkdata=file:///path_to_json_repots_storage/A002_pgversion.json --outdir=/path_to_md_reports_storage/ `

		also for enable debug mode add option `--debug 1`

Dmius repgen 86 #100

Dmius repgen 86 #100

Uh oh!

Conversation

dmius commented Nov 30, 2018

Uh oh!

Nastradamus commented Nov 30, 2018

Uh oh!

Nastradamus commented Nov 30, 2018

Uh oh!

dmius commented Nov 30, 2018

Uh oh!

NikolayS Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

NikolayS Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

NikolayS Dec 3, 2018

Choose a reason for hiding this comment

Uh oh!

NikolayS Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NikolayS commented Dec 3, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Nastradamus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NikolayS Dec 3, 2018 •

edited

Loading

NikolayS commented Dec 3, 2018 •

edited

Loading