Skip to content
This repository was archived by the owner on Jul 6, 2021. It is now read-only.

add a new wrapper 'CHECK_HOST_CMD' - to change 'ssh' #112

Merged
merged 5 commits into from
Dec 5, 2018
Merged

add a new wrapper 'CHECK_HOST_CMD' - to change 'ssh' #112

merged 5 commits into from
Dec 5, 2018

Conversation

Nastradamus
Copy link
Contributor

@Nastradamus Nastradamus commented Dec 4, 2018 •
edited by NikolayS
Loading

  • Implement wrapper $CHECK_HOST_CMD to ssh/bash
  • Rewrite all check scipts with support of new wrapper

@Nastradamus Nastradamus changed the title [WIP]: add a new wrapper 'CHECK_HOST_CMD' - to change 'ssh' add a new wrapper 'CHECK_HOST_CMD' - to change 'ssh' Dec 4, 2018
@Nastradamus Nastradamus requested review from NikolayS and dmius December 4, 2018 12:53
NikolayS
NikolayS approved these changes Dec 5, 2018
View reviewed changes
Copy link
Collaborator

@NikolayS NikolayS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good 👍
Haven't checked it (remote psql calls) yet. By the way, do you see any way to test it automatically in CI? (it's not a requirement now, but in the future, we definitely need to setup CI)

@Nastradamus
Copy link
Contributor Author

@NikolayS , yes I want tests and understand how to test it. We need containers with working streaming replication.

@Nastradamus Nastradamus merged commit 61c9e9b into master Dec 5, 2018
@NikolayS NikolayS deleted the 107-psql-only-support branch December 7, 2018 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NikolayS NikolayS NikolayS approved these changes

@dmius dmius Awaiting requested review from dmius

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nastradamus @NikolayS