This repository was archived by the owner on Jul 6, 2021. It is now read-only.
get all .md reports at once #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nastradamus
changed the title
NikolayS
reviewed
Dec 5, 2018
check
Outdated
| if [[ "${KERNEL_NAME}" = "Darwin" ]]; then | ||
| err "${OS_NAME}: 'brew install coreutils'" | ||
| elif [[ "${KERNEL_NAME}" = "Linux" ]]; then | ||
| err "Ubuntu or Debian GNU/${OS_NAME}: 'apt-get install coreutils'" |
There was a problem hiding this comment.
sudo apt-get ...?
and RHEL/CentOS: 'sudo yum install ...' ?
NikolayS
reviewed
Dec 5, 2018
check
Outdated
| elif [[ "${KERNEL_NAME}" = "Linux" ]]; then | ||
| err "Ubuntu or Debian GNU/${OS_NAME}: 'apt-get install coreutils'" | ||
| fi | ||
| return 2 |
There was a problem hiding this comment.
why 2 here? maybe it's worth to document the meaning of every returned value?
There was a problem hiding this comment.
I don't think it's woth it, because error reporting handler will show function name and even the line number of error: easy to understand "what's happening".
|
This looks awesome! One thing -- it looks like the current code doesn't check |
|
Fixed all commented things. |
dmius
approved these changes
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.