Skip to content
This repository was archived by the owner on Jul 6, 2021. It is now read-only.

G001 check with template #134

Merged
merged 2 commits into from
Dec 10, 2018
Merged

G001 check with template #134

merged 2 commits into from
Dec 10, 2018

Conversation

dmius
Copy link
Collaborator

@dmius dmius commented Dec 10, 2018

No description provided.

Nastradamus
Nastradamus suggested changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@Nastradamus Nastradamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add temp_buffers

Nastradamus
Nastradamus approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@Nastradamus Nastradamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
image

For the future: I don't think we need to know about "who is master" in every report.
We need to move some logic to the external template (as for why template was conceived for).

@dmius dmius mentioned this pull request Dec 10, 2018
Closed
@dmius dmius merged commit 99a7eaa into master Dec 10, 2018
@NikolayS NikolayS deleted the dmius-g001 branch December 14, 2018 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nastradamus Nastradamus Nastradamus approved these changes

@NikolayS NikolayS Awaiting requested review from NikolayS

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmius @Nastradamus