This repository was archived by the owner on Jul 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nastradamus
suggested changes
Nov 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't work in macOS.
Try to avoid sed
. As I said before, sed
in Linux and sed
in macOS and sed
in FreeBSD - three different programms:
[2018-11-29T13:51:40+0300] ========== Perform check: ==========
[2018-11-29T13:51:40+0300] ./resources/checks/F001_heap_bloat.sh
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
(23) Failed writing body
[2018-11-29T13:51:41+0300] ========== End of check ===========
[2018-11-29T13:51:41+0300] WARNING: check 'F001_heap' failed with error ^^^
[2018-11-29T13:51:41+0300]
[2018-11-29T13:51:41+0300] ========== Perform check: ==========
[2018-11-29T13:51:41+0300] ./resources/checks/F002_index_bloat.sh
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
(23) Failed writing body
[2018-11-29T13:51:43+0300] ========== End of check ===========
[2018-11-29T13:51:43+0300] WARNING: check 'F002_index' failed with error ^^^
NikolayS
reviewed
Nov 30, 2018
NikolayS
reviewed
Nov 30, 2018
NikolayS
reviewed
Nov 30, 2018
NikolayS
reviewed
Nov 30, 2018
@dmius please mark resolved questions (button "Resolve conversation") and let us know when this PR is ready. |
@NikolayS @Nastradamus Ready. |
NikolayS
approved these changes
Dec 3, 2018
Thanks! Looks good to me 👍 |
Nastradamus
suggested changes
Dec 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it ok?
[2018-12-04T11:02:35+0300] Artifacts saved at: './artifacts/dummy/2018_12_04T11_02_35_+0300/F002_index_bloat.json'
{
"project": "dummy",
"name": "bloat",
"checkId": "F001_heap",
"epoch": null,
"timestamptz": "2018-12-04 11:02:34.0+0300",
"hosts": [
null
],
"dependencies": {
"null": "null"
},
"results": {
"dev": []
}
}
Nastradamus
approved these changes
Dec 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now everything is ok. Let's merge it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.