Skip to content
This repository was archived by the owner on Jul 6, 2021. It is now read-only.

#87 #88 F001 and F002 checks #95

Merged
merged 4 commits into from
Dec 4, 2018
Merged

#87 #88 F001 and F002 checks #95

merged 4 commits into from
Dec 4, 2018

Conversation

dmius
Copy link
Collaborator

@dmius dmius commented Nov 28, 2018

No description provided.

Copy link
Contributor

@Nastradamus Nastradamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work in macOS.

Try to avoid sed. As I said before, sed in Linux and sed in macOS and sed in FreeBSD - three different programms:

[2018-11-29T13:51:40+0300] ========== Perform check: ==========
[2018-11-29T13:51:40+0300] ./resources/checks/F001_heap_bloat.sh
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
(23) Failed writing body
[2018-11-29T13:51:41+0300] ========== End of check ===========
[2018-11-29T13:51:41+0300] WARNING: check 'F001_heap' failed with error ^^^
[2018-11-29T13:51:41+0300]
[2018-11-29T13:51:41+0300] ========== Perform check: ==========
[2018-11-29T13:51:41+0300] ./resources/checks/F002_index_bloat.sh
sed: illegal option -- r
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]
(23) Failed writing body
[2018-11-29T13:51:43+0300] ========== End of check ===========
[2018-11-29T13:51:43+0300] WARNING: check 'F002_index' failed with error ^^^

@NikolayS
Copy link
Collaborator

NikolayS commented Dec 3, 2018

@dmius please mark resolved questions (button "Resolve conversation") and let us know when this PR is ready.

@dmius
Copy link
Collaborator Author

dmius commented Dec 3, 2018

@NikolayS @Nastradamus Ready.

@NikolayS
Copy link
Collaborator

NikolayS commented Dec 3, 2018

Thanks! Looks good to me 👍

Copy link
Contributor

@Nastradamus Nastradamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ok?

[2018-12-04T11:02:35+0300] Artifacts saved at: './artifacts/dummy/2018_12_04T11_02_35_+0300/F002_index_bloat.json'

{
  "project": "dummy",
  "name": "bloat",
  "checkId": "F001_heap",
  "epoch": null,
  "timestamptz": "2018-12-04 11:02:34.0+0300",
  "hosts": [
    null
  ],
  "dependencies": {
    "null": "null"
  },
  "results": {
    "dev": []
  }
}

Copy link
Contributor

@Nastradamus Nastradamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything is ok. Let's merge it?

@dmius dmius merged commit 5d21a99 into master Dec 4, 2018
@dmius dmius deleted the dmius-87-f001 branch December 4, 2018 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants