[Issue #240] bugfix #299
Closed
[Issue #240] bugfix #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xectuion of async task, save the error message and return it when requested. Also handle the SIGPIPE signal.
| int | ||
| fio_check_error_fd_gz(gzFile f, char **errmsg) | ||
| { | ||
| if (f && ((size_t)f & FIO_GZ_REMOTE_MARKER)) |
There was a problem hiding this comment.
Could you please add a comment to FIO_GZ_REMOTE_MARKER definition?
|
|
||
| //TODO: should we reset the tainted state ? | ||
| // pg_free(async_errormsg); | ||
| // async_errormsg = NULL; |
There was a problem hiding this comment.
I don't see, where we reset async_errormsg.
How would we handle several consecutive errors?
There was a problem hiding this comment.
We don`t. Currently it is assumed, that a first error is the last error.
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When remote agent encounters an error condition during exectuion of async task, save the error message and return it when requested. Also handle the SIGPIPE signal.