Release 2 6 refactoring #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into new fio_remove() with proper error checking
I prefer the declaration in form 'char const', but in the source code the form 'const char' is used more often
…eviosly errors was not checked
Previously, the return code was not checked when deleting files. Now, in order for the tests to work out, you need to ignore the missing files. This fix for tests: tests.retention.RetentionTest.test_window_merge_interleaved_incremental_chains_1 tests.retention.RetentionTest.test_window_chains tests.merge.MergeTest.test_smart_merge tests.merge.MergeTest.test_merge_tablespaces tests.merge.MergeTest.test_merge_pg_filenode_map tests.merge.MergeTest.test_failed_merge_after_delete_3 tests.merge.MergeTest.test_failed_merge_after_delete tests.merge.MergeTest.test_crash_after_opening_backup_control_2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.