Skip to content

[tests] Assert messages in ConfigTest are corrected #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[tests] Assert messages in ConfigTest are corrected #632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[tests] Assert messages in ConfigTest are corrected 
test_corrupt_backup_content generates an incorrect assert message that was gotten (through copy&paste) from test_remove_instance_config.

Both messages in test_remove_instance_config and test_corrupt_backup_content were reformatted to use a unified structure.
  • Loading branch information
@dmitry-lipetsk
dmitry-lipetsk committed Jul 25, 2024
commit 20ea70d3524b2dc58e2fd15bf3ec85a3d4a4e118
8 changes: 4 additions & 4 deletions tests/config_test.py
View file
Original file line number Diff line number Diff line change
@@ -39,8 +39,8 @@ def test_remove_instance_config(self):
backup_dir, 'node', node, backup_type='page')
self.assertEqual(
1, 0,
"Expecting Error because pg_probackup.conf is missing. "
".\n Output: {0} \n CMD: {1}".format(
"Expecting Error because pg_probackup.conf is missing"
"\n Output: {0} \n CMD: {1}".format(
repr(self.output), self.cmd))
except ProbackupException as e:
self.assertIn(
@@ -85,8 +85,8 @@ def test_corrupt_backup_content(self):
self.validate_pb(backup_dir, 'node')
self.assertEqual(
1, 0,
"Expecting Error because pg_probackup.conf is missing. "
".\n Output: {0} \n CMD: {1}".format(
"Expecting Error because backup_content.control of the first backup was corrupted intentionally"
"\n Output: {0} \n CMD: {1}".format(
repr(self.output), self.cmd))
except ProbackupException as e:
self.assertIn(